Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-activate reorg support #737

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

boecklim
Copy link
Collaborator

@boecklim boecklim commented Jan 9, 2025

Description of Changes

Reorg-support has ben temporarily disabled. This PR re-enables it with a specific setting that decides whether a new block is considered from the longest blockchain or if the status should be assigned according to reorg-support.

Linked Issues / Tickets

Extends #736

Testing Procedure

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes

@boecklim boecklim changed the title Feat/reactivate reorg support feat: re-activate reorg support Jan 9, 2025
@boecklim boecklim marked this pull request as ready for review January 9, 2025 16:05
@boecklim boecklim self-assigned this Jan 9, 2025
Base automatically changed from refactor/calc-merkle-paths to main January 10, 2025 14:06
@boecklim boecklim force-pushed the feat/reactivate-reorg-support branch from e97e4a5 to e680830 Compare January 10, 2025 15:35
@boecklim boecklim force-pushed the feat/reactivate-reorg-support branch 3 times, most recently from 1f9e01d to 15414b3 Compare January 15, 2025 09:39
@boecklim boecklim changed the base branch from main to refactor/block-processing January 15, 2025 09:44
@boecklim boecklim force-pushed the feat/reactivate-reorg-support branch 4 times, most recently from 0ecde3c to 78fc981 Compare January 15, 2025 10:29
Base automatically changed from refactor/block-processing to main January 15, 2025 13:22
@boecklim boecklim force-pushed the feat/reactivate-reorg-support branch 2 times, most recently from 480cade to 4417bb8 Compare January 16, 2025 14:18
@boecklim boecklim force-pushed the feat/reactivate-reorg-support branch from 4417bb8 to 5885e6e Compare January 16, 2025 14:24
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
54.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants