Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacetor beef function and support V2 BEEF with NewBEEFFromBytes #68

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sirdeggen
Copy link
Contributor

Description of Changes

Provide a brief description of the changes you've made.

Linked Issues / Tickets

Reference any related issues or tickets, e.g. "Closes #123".

Testing Procedure

Describe the tests you've added or any testing steps you've taken.

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment
  • All tests pass when using go test ./...

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes
  • I ran golangci-lint run
  • I have run go fmt and go vet one final time before requesting a review

Signed-off-by: sirdeggen <d.kellenschwiler@bsvblockchain.org>
Signed-off-by: sirdeggen <d.kellenschwiler@bsvblockchain.org>
Signed-off-by: Deggen <d.kellenschwiler@bsvblockchain.org>
Signed-off-by: sirdeggen <d.kellenschwiler@bsvblockchain.org>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant