Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BUX-190): add keys generation #166

Merged
merged 6 commits into from
Dec 21, 2023

Conversation

pawellewandowski98
Copy link
Contributor

Description

  • Added methods to generate random set of keys and to get pub from xpriv

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@pawellewandowski98 pawellewandowski98 self-assigned this Oct 18, 2023
@mergify mergify bot added the feature Any new significant addition label Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 124 lines in your changes are missing coverage. Please review.

Comparison is base (c7df2a4) 38.83% compared to head (8d495cf) 37.44%.
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
- Coverage   38.83%   37.44%   -1.40%     
==========================================
  Files          21       23       +2     
  Lines        2585     2681      +96     
==========================================
  Hits         1004     1004              
- Misses       1495     1591      +96     
  Partials       86       86              
Flag Coverage Δ
unittests 37.44% <0.00%> (-1.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
examples/graphql/graphql.go 0.00% <0.00%> (ø)
examples/http/http.go 0.00% <0.00%> (ø)
examples/new_paymail/new_paymail.go 0.00% <0.00%> (ø)
examples/register_xpub/register_xpub.go 0.00% <0.00%> (ø)
examples/keys/keys.go 0.00% <0.00%> (ø)
xpriv/xpriv.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7df2a4...8d495cf. Read the comment docs.

examples/keys/keys.go Show resolved Hide resolved
examples/keys/keys.go Outdated Show resolved Hide resolved
examples/keys/keys.go Outdated Show resolved Hide resolved
utils/utils.go Outdated Show resolved Hide resolved
utils/utils.go Outdated Show resolved Hide resolved
utils/utils.go Outdated Show resolved Hide resolved
xkeys/xkeys.go Outdated Show resolved Hide resolved
xkeys/xkeys.go Outdated Show resolved Hide resolved
@mergify mergify bot closed this Nov 8, 2023
Copy link
Contributor

mergify bot commented Nov 8, 2023

This pull request looks stale. Feel free to reopen it if you think it's a mistake.

@mergify mergify bot added the stale Old, unused, stale label Nov 8, 2023
@pawellewandowski98 pawellewandowski98 marked this pull request as ready for review November 15, 2023 10:24
@pawellewandowski98 pawellewandowski98 requested a review from a team as a code owner November 15, 2023 10:24
xpriv/xpriv.go Outdated Show resolved Hide resolved
xpriv/xpriv.go Outdated Show resolved Hide resolved
xpriv/xpriv.go Outdated Show resolved Hide resolved
@pawellewandowski98 pawellewandowski98 requested a review from a team as a code owner December 20, 2023 10:11
@pawellewandowski98 pawellewandowski98 merged commit d4d7543 into master Dec 21, 2023
4 of 5 checks passed
@mergify mergify bot deleted the feat-add-keys-generation branch December 21, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Any new significant addition stale Old, unused, stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants