-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUX-202: Logging #168
BUX-202: Logging #168
Conversation
Welcome to our open-source project @Nazarii-4chain! π |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #168 +/- ##
==========================================
+ Coverage 40.36% 41.30% +0.93%
==========================================
Files 16 17 +1
Lines 2492 2668 +176
==========================================
+ Hits 1006 1102 +96
- Misses 1400 1477 +77
- Partials 86 89 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a short discussion, the team has decided to completely remove logs from the library. Please review if we can also eliminate the debug flag.
Pull Request Checklist
Added logger