Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUX-202: Logging #168

Closed
wants to merge 7 commits into from
Closed

BUX-202: Logging #168

wants to merge 7 commits into from

Conversation

Nazarii-4chain
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

Added logger

@Nazarii-4chain Nazarii-4chain requested a review from a team as a code owner December 6, 2023 08:42
@Nazarii-4chain Nazarii-4chain self-assigned this Dec 6, 2023
@mergify mergify bot added the feature Any new significant addition label Dec 6, 2023
Copy link
Contributor

mergify bot commented Dec 6, 2023

Welcome to our open-source project @Nazarii-4chain! πŸ’˜

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 180 lines in your changes are missing coverage. Please review.

Comparison is base (0dc9233) 40.36% compared to head (a987fe8) 41.30%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   40.36%   41.30%   +0.93%     
==========================================
  Files          16       17       +1     
  Lines        2492     2668     +176     
==========================================
+ Hits         1006     1102      +96     
- Misses       1400     1477      +77     
- Partials       86       89       +3     
Flag Coverage Ξ”
unittests 41.30% <14.69%> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
logger/logger.go 100.00% <100.00%> (ΓΈ)
transports/errors.go 83.33% <100.00%> (+0.57%) ⬆️
transports/transports.go 75.75% <33.33%> (-4.25%) ⬇️
transactions.go 48.48% <0.00%> (-4.85%) ⬇️
buxclient.go 80.48% <42.85%> (-3.52%) ⬇️
transports/authentication.go 54.49% <10.52%> (-5.65%) ⬇️
transports/graphql_admin.go 5.65% <4.00%> (-0.08%) ⬇️
transports/http_admin.go 4.88% <0.00%> (-0.51%) ⬇️
transports/graphql.go 52.70% <11.11%> (+3.82%) ⬆️
transports/http.go 34.33% <13.75%> (+1.49%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 0dc9233...a987fe8. Read the comment docs.

logger/logger.go Show resolved Hide resolved
transactions.go Outdated Show resolved Hide resolved
transactions.go Outdated Show resolved Hide resolved
Copy link
Contributor

@arkadiuszos4chain arkadiuszos4chain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a short discussion, the team has decided to completely remove logs from the library. Please review if we can also eliminate the debug flag.

@Nazarii-4chain Nazarii-4chain marked this pull request as draft December 28, 2023 10:24
@Nazarii-4chain Nazarii-4chain marked this pull request as ready for review December 29, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Any new significant addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants