Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SPV-846): refactor numeric error codes into strings #245

Merged
merged 4 commits into from
Jul 4, 2024
Merged

feat(SPV-846): refactor numeric error codes into strings #245

merged 4 commits into from
Jul 4, 2024

Conversation

pawellewandowski98
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

Description

  • Adjust errors to new structure

@pawellewandowski98 pawellewandowski98 self-assigned this Jun 26, 2024
@pawellewandowski98 pawellewandowski98 requested a review from a team as a code owner June 26, 2024 08:58
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 26, 2024 •
edited
Loading

Manual Tests

πŸ’š Manual testing by @chris-4chain resulted in success.

@pawellewandowski98 pawellewandowski98 force-pushed the feat-846-refactor-numeric-error-codes-into-strings branch from 740dcf6 to 355b613 Compare June 26, 2024 09:01
ac4ch
ac4ch reviewed Jun 26, 2024
View reviewed changes
authentication.go Outdated Show resolved Hide resolved
ac4ch
ac4ch reviewed Jun 26, 2024
View reviewed changes
Copy link
Contributor

@ac4ch ac4ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok done here too

chris-4chain
chris-4chain requested changes Jul 3, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@chris-4chain @pawellewandowski98
fix(SPV-846): handle exeptions example (#248)
b5b1a5f 
Co-authored-by: PaweΕ‚ Lewandowski <plewandowski555@gmail.com>
@chris-4chain chris-4chain added the tested PR was tested by a team member label Jul 4, 2024
@pawellewandowski98 pawellewandowski98 merged commit 5305b41 into main Jul 4, 2024
9 checks passed
@pawellewandowski98 pawellewandowski98 deleted the feat-846-refactor-numeric-error-codes-into-strings branch July 4, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ac4ch ac4ch ac4ch left review comments

@chris-4chain chris-4chain chris-4chain approved these changes

@dorzepowski dorzepowski dorzepowski approved these changes

Assignees

@pawellewandowski98 pawellewandowski98

Labels
tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pawellewandowski98 @dorzepowski @ac4ch @chris-4chain