Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SPV-896): Regression tests v1 #252

Merged
merged 20 commits into from
Aug 16, 2024
Merged

feat(SPV-896): Regression tests v1 #252

merged 20 commits into from
Aug 16, 2024

Conversation

jakubmkowalski
Copy link
Contributor

@jakubmkowalski jakubmkowalski commented Jul 19, 2024 •
edited
Loading

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 19, 2024 •
edited
Loading

Manual Tests

💚 Manual testing by @wregulski resulted in success.

@jakubmkowalski jakubmkowalski self-assigned this Jul 19, 2024
@jakubmkowalski jakubmkowalski marked this pull request as ready for review July 19, 2024 16:38
@jakubmkowalski jakubmkowalski requested a review from a team as a code owner July 19, 2024 16:38
ac4ch
ac4ch reviewed Jul 22, 2024
View reviewed changes
regression_tests/utils.go Outdated Show resolved Hide resolved
regression_tests/utils.go Outdated Show resolved Hide resolved
regression_tests/utils.go Outdated Show resolved Hide resolved
regression_tests/utils.go Outdated Show resolved Hide resolved
regression_tests/regression_test.go Show resolved Hide resolved
dorzepowski
dorzepowski requested changes Aug 6, 2024
View reviewed changes
regression_tests/regression_test.go Outdated Show resolved Hide resolved
regression_tests/regression_test.go Outdated Show resolved Hide resolved
regression_tests/utils.go Outdated Show resolved Hide resolved
regression_tests/utils.go Outdated Show resolved Hide resolved
regression_tests/regression_test.go Outdated Show resolved Hide resolved
regression_tests/regression_test.go Outdated Show resolved Hide resolved
regression_tests/regression_test.go Outdated Show resolved Hide resolved
regression_tests/regression_test.go Outdated Show resolved Hide resolved
regression_tests/regression_test.go Outdated Show resolved Hide resolved
regression_tests/regression_test.go Outdated Show resolved Hide resolved
dorzepowski
dorzepowski requested changes Aug 12, 2024
View reviewed changes
regression_tests/utils.go Outdated Show resolved Hide resolved
@wregulski wregulski added the tested PR was tested by a team member label Aug 16, 2024
@wregulski wregulski merged commit 46bbd35 into main Aug 16, 2024
10 checks passed
@wregulski wregulski deleted the feat-896-regression-tests-v1 branch August 16, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ac4ch ac4ch ac4ch left review comments

@wregulski wregulski wregulski approved these changes

@dorzepowski dorzepowski dorzepowski approved these changes

Assignees

@jakubmkowalski jakubmkowalski

Labels
tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakubmkowalski @dorzepowski @wregulski @ac4ch