Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SPV-1225): add admin confirmation for contacts #301

Merged
merged 5 commits into from
Dec 11, 2024
Merged

feat(SPV-1225): add admin confirmation for contacts #301

merged 5 commits into from
Dec 11, 2024

Conversation

jakubmkowalski
Copy link
Contributor

@jakubmkowalski jakubmkowalski commented Dec 4, 2024 •
edited
Loading

This pull request introduces a new method to the WalletClient struct in the http.go file. The key change is the addition of the AdminConfirmContacts function, which allows for the confirmation of contacts via an HTTP POST request.

New functionality:

  • http.go: Added the AdminConfirmContacts method to the WalletClient struct to enable contact confirmation using xPubs IDs and paymails.

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@jakubmkowalski jakubmkowalski self-assigned this Dec 4, 2024
@jakubmkowalski jakubmkowalski requested a review from a team as a code owner December 4, 2024 12:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024 •
edited
Loading

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

ac4ch
ac4ch requested changes Dec 4, 2024
View reviewed changes
http.go Outdated Show resolved Hide resolved
@dzolt-4chain dzolt-4chain added the tested PR was tested by a team member label Dec 11, 2024
@dzolt-4chain dzolt-4chain added tested PR was tested by a team member and removed tested PR was tested by a team member labels Dec 11, 2024
@jakubmkowalski jakubmkowalski merged commit 3d7a6f8 into main Dec 11, 2024
11 of 12 checks passed
@jakubmkowalski jakubmkowalski deleted the feat/SPV-1225-admin-confirm-contacts branch December 11, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzolt-4chain dzolt-4chain dzolt-4chain approved these changes

@ac4ch ac4ch ac4ch approved these changes

Assignees

@jakubmkowalski jakubmkowalski

Labels
tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakubmkowalski @ac4ch @dzolt-4chain