Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-1340): fix CreatePaymail model #1131

Merged
merged 2 commits into from
Jan 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/admin-add-user.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ const adminClient = new SpvWalletClient(server, {
const newXPubRes = await adminClient.AdminNewXpub(exampleXPub, { some_metadata: 'example' });
console.log('AdminNewXpub response:', newXPubRes);

const createPaymailRes = await adminClient.AdminCreatePaymail(exampleXPub, examplePaymail, 'Some public name', '');
const createPaymailRes = await adminClient.AdminCreatePaymail(exampleXPub, examplePaymail, 'Some public name', '', {});
console.log('AdminCreatePaymail response:', createPaymailRes);
6 changes: 3 additions & 3 deletions src/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -341,22 +341,22 @@ export class SpvWalletClient {
*
* @param {string} rawXPub Raw xPub to register the paymail to
* @param {string} address Paymail address (i.e. alias@example.com)
* @param {string} public_name Public name for the user to return in Paymail address resolution requests
* @param {string} publicName Public name for the user to return in Paymail address resolution requests
* @param {string} avatar Avatar of the user to return in Paymail address resolution requests
* @return {PaymailAddress}
*/
async AdminCreatePaymail(
rawXPub: string,
address: string,
public_name: string,
publicName: string,
avatar: string,
metadata: Metadata,
): Promise<PaymailAddress> {
return await this.http.adminRequest(`admin/paymails`, 'POST', {
metadata,
key: rawXPub,
address,
public_name,
publicName,
avatar,
});
}
Expand Down
Loading