Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(BUX-426): BroadcastClientAPIs as struct #386

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

chris-4chain
Copy link
Contributor

@chris-4chain chris-4chain commented Dec 28, 2023

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

Previous config for nodes/broadcast_client_apis looked like this:

nodes:
  broadcast_client_apis: ["URL", "URL2|TOKEN2"]

where the vertical bar | was a separator.

In this PR I'm proposing a more standard approach using structs, like this:

nodes:
  broadcast_client_apis:
    - url: https://arc.gorillapool.io

    - url: https://tapi.taal.com/arc
      token: <TOKEN>
nodes:
  broadcast_client_apis:
    - url: https://arc.gorillapool.io
    - url: https://some_open_arc.com
nodes:
  broadcast_client_apis:
    - url: https://arc.gorillapool.io
      token:
nodes:
  broadcast_client_apis: []

The token is optional.

@chris-4chain chris-4chain requested a review from a team as a code owner December 28, 2023 11:42
@mergify mergify bot added the update General updates label Dec 28, 2023
Copy link
Contributor

mergify bot commented Dec 28, 2023

Welcome to our open-source project @chris-4chain! πŸ’˜

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (aa41772) 39.02% compared to head (d7633db) 39.16%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
+ Coverage   39.02%   39.16%   +0.14%     
==========================================
  Files          44       44              
  Lines        1576     1560      -16     
==========================================
- Hits          615      611       -4     
+ Misses        928      917      -11     
+ Partials       33       32       -1     
Flag Coverage Ξ”
unittests 39.16% <16.66%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
config/config.go 100.00% <ΓΈ> (ΓΈ)
config/defaults.go 100.00% <100.00%> (ΓΈ)
config/services.go 45.48% <0.00%> (+1.07%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update aa41772...d7633db. Read the comment docs.

@mergify mergify bot merged commit 2ec958d into master Dec 28, 2023
11 checks passed
@mergify mergify bot deleted the chore-426-BroadcastClientAPIs-as-struct branch December 28, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update General updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants