Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(BUX-456): config validation first #397

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

chris-4chain
Copy link
Contributor

@chris-4chain chris-4chain commented Jan 9, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@chris-4chain chris-4chain requested a review from a team as a code owner January 9, 2024 07:32
Copy link
Contributor

mergify bot commented Jan 9, 2024

Welcome to our open-source project @chris-4chain! πŸ’˜

@mergify mergify bot added the update General updates label Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (9295419) 40.25% compared to head (407a3c5) 40.21%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
- Coverage   40.25%   40.21%   -0.04%     
==========================================
  Files          46       46              
  Lines        1642     1641       -1     
==========================================
- Hits          661      660       -1     
  Misses        944      944              
  Partials       37       37              
Flag Coverage Ξ”
unittests 40.21% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
config/validate.go 100.00% <100.00%> (ΓΈ)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 9295419...407a3c5. Read the comment docs.

@chris-4chain chris-4chain merged commit 9dea5e9 into master Jan 9, 2024
10 checks passed
@kuba-4chain kuba-4chain deleted the chore-456-config-validation-first branch January 9, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update General updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants