-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(BUX-461) fee quotes for both arc and mAPI with user defined fee quote #403
Conversation
Welcome to our open-source project @chris-4chain! π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check tests
Tests will pass after |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #403 +/- ##
==========================================
+ Coverage 40.18% 40.61% +0.42%
==========================================
Files 46 46
Lines 1640 1667 +27
==========================================
+ Hits 659 677 +18
- Misses 944 950 +6
- Partials 37 40 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Pull Request Checklist
This new version introduces new config field:
nodes.fee_unit
and movesnodes.mapi.use_fee_quotes
tonodes.use_fee_quotes
. This change is made because the setting is now applicable to both the ARC and mAPI protocols.When
nodes.fee_unit
is defined, it will be used as the offered fee to miners when use_fee_quotes is disabled.However, by default,
use_fee_quotes
is enabled, so during the initialization stage, the lowest fee among the fee quotes from configured miners will be selected.When neither
nodes.use_fee_quotes
nornodes.fee_unit
is set, the config validation will fail and the application won't start.Requires new bux version (BuxOrg/bux#533)