Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bux 478: update destination metadata #414

Merged
merged 7 commits into from
Jan 23, 2024

Conversation

Nazarii-4chain
Copy link
Contributor

Fixed error message

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@Nazarii-4chain Nazarii-4chain self-assigned this Jan 19, 2024
@Nazarii-4chain Nazarii-4chain requested a review from a team as a code owner January 19, 2024 12:00
@mergify mergify bot added the feature Any new significant addition label Jan 19, 2024
Copy link
Contributor

mergify bot commented Jan 19, 2024

Welcome to our open-source project @Nazarii-4chain! πŸ’˜

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (51125d2) 40.61% compared to head (4c7de85) 40.61%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #414   +/-   ##
=======================================
  Coverage   40.61%   40.61%           
=======================================
  Files          46       46           
  Lines        1667     1667           
=======================================
  Hits          677      677           
  Misses        950      950           
  Partials       40       40           
Flag Coverage Ξ”
unittests 40.61% <0.00%> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
actions/destinations/update.go 0.00% <0.00%> (ΓΈ)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 51125d2...4c7de85. Read the comment docs.

@Nazarii-4chain Nazarii-4chain merged commit c260f3a into master Jan 23, 2024
7 checks passed
@Nazarii-4chain Nazarii-4chain deleted the feat/BUX-478/UpdateDestinationMetadata branch January 23, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Any new significant addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants