-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(BUX-506): update bux-server config description #419
chore(BUX-506): update bux-server config description #419
Conversation
Welcome to our open-source project @pawellewandowski98! π |
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## master #419 +/- ##
=======================================
Coverage 39.64% 39.64%
=======================================
Files 47 47
Lines 1710 1710
=======================================
Hits 678 678
Misses 992 992
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
97b79ed
to
82625f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally - I'm wondering if the underscore-prefixed fields e.g. _beef:
with a comment Prefixed with "_", because it's unused by default
make sense now. Maybe it would be better to set all
fields in config.example
and put an appropriate NOTE in the README.
13da7ca
to
d741e9e
Compare
Pull Request Checklist
Description