Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BUX-512): checking pulse connection on startup & enabled Beef as default #423

Merged
merged 5 commits into from
Jan 25, 2024

Conversation

chris-4chain
Copy link
Contributor

@chris-4chain chris-4chain commented Jan 25, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@chris-4chain chris-4chain requested a review from a team as a code owner January 25, 2024 11:24
Copy link
Contributor

mergify bot commented Jan 25, 2024

Welcome to our open-source project @chris-4chain! πŸ’˜

@mergify mergify bot added the feature Any new significant addition label Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (8675080) 40.58% compared to head (4e63f75) 39.64%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
- Coverage   40.58%   39.64%   -0.95%     
==========================================
  Files          46       47       +1     
  Lines        1663     1710      +47     
==========================================
+ Hits          675      678       +3     
- Misses        947      992      +45     
+ Partials       41       40       -1     
Flag Coverage Ξ”
unittests 39.64% <2.08%> (-0.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
config/defaults.go 100.00% <100.00%> (ΓΈ)
config/check_pulse.go 0.00% <0.00%> (ΓΈ)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 8675080...4e63f75. Read the comment docs.

@chris-4chain chris-4chain merged commit 6f0573e into master Jan 25, 2024
9 of 11 checks passed
@chris-4chain chris-4chain deleted the feat-512-check-pulse branch January 25, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Any new significant addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants