Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(BUX-586): renames bux-server to spv-wallet #465

Merged
merged 54 commits into from
Feb 22, 2024
Merged

Conversation

jakubmkowalski
Copy link
Contributor

@jakubmkowalski jakubmkowalski commented Feb 13, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

For testing, until the rest of the application is migrated,
change all occurrences(except swagger, of course) of
x-auth....
to
bux-auth....

Copy link

github-actions bot commented Feb 13, 2024

Manual Tests

πŸ’š Manual testing by @arkadiuszos4chain resulted in success.

@mergify mergify bot added the update General updates label Feb 13, 2024
Copy link
Contributor

mergify bot commented Feb 13, 2024

Welcome to our open-source project @jakubmkowalski! πŸ’˜

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 1457 lines in your changes are missing coverage. Please review.

Comparison is base (dd7aec2) 40.40% compared to head (f06685a) 56.96%.
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #465       +/-   ##
===========================================
+ Coverage   40.40%   56.96%   +16.55%     
===========================================
  Files          48      149      +101     
  Lines        1339     8662     +7323     
===========================================
+ Hits          541     4934     +4393     
- Misses        757     3250     +2493     
- Partials       41      478      +437     
Flag Coverage Ξ”
unittests 56.96% <56.32%> (+16.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
actions/access_keys/routes.go 100.00% <ΓΈ> (ΓΈ)
actions/base/routes.go 100.00% <ΓΈ> (ΓΈ)
actions/destinations/routes.go 100.00% <ΓΈ> (ΓΈ)
actions/transactions/routes.go 100.00% <ΓΈ> (ΓΈ)
actions/utxos/routes.go 100.00% <ΓΈ> (ΓΈ)
actions/xpubs/routes.go 100.00% <ΓΈ> (ΓΈ)
config/config.go 100.00% <100.00%> (ΓΈ)
config/defaults.go 100.00% <100.00%> (ΓΈ)
config/load.go 68.62% <100.00%> (ΓΈ)
config/validate_paymail.go 86.66% <100.00%> (ΓΈ)
... and 127 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update dd7aec2...f06685a. Read the comment docs.

.github/CODEOWNERS Outdated Show resolved Hide resolved
actions/access_keys/count.go Outdated Show resolved Hide resolved
actions/access_keys/count.go Outdated Show resolved Hide resolved
actions/destinations/search.go Outdated Show resolved Hide resolved
cmd/server/main.go Outdated Show resolved Hide resolved
LICENSE Show resolved Hide resolved
actions/access_keys/create.go Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
config/load.go Outdated Show resolved Hide resolved
@wregulski
Copy link
Contributor

I think you should update Dockerfile and docker-compose names

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
config.example.yaml Outdated Show resolved Hide resolved
config.example.yaml Outdated Show resolved Hide resolved
engine/.yamllint.yml Outdated Show resolved Hide resolved
engine/LICENSE Outdated Show resolved Hide resolved
engine/Makefile Outdated Show resolved Hide resolved
engine/README.md Outdated Show resolved Hide resolved
spv_wallet.go Outdated Show resolved Hide resolved
models/Makefile Outdated Show resolved Hide resolved
models/.yamllint.yml Outdated Show resolved Hide resolved
models/.golangci.yml Outdated Show resolved Hide resolved
models/.gitignore Outdated Show resolved Hide resolved
models/.editorconfig Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
@jakubmkowalski jakubmkowalski marked this pull request as ready for review February 21, 2024 10:48
@jakubmkowalski jakubmkowalski requested a review from a team as a code owner February 21, 2024 10:48
mappings/common/common.go Outdated Show resolved Hide resolved
engine/bux_suite_database_test.go Outdated Show resolved Hide resolved
@arkadiuszos4chain arkadiuszos4chain added the tested PR was tested by a team member label Feb 21, 2024
@dorzepowski dorzepowski merged commit 37dda37 into master Feb 22, 2024
8 checks passed
@dorzepowski dorzepowski deleted the chore/586-rename branch February 22, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member update General updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants