Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(SPV-1114): setup builds to publish images also on AWS ECR public repo. #747

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

dorzepowski
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@dorzepowski dorzepowski requested a review from a team as a code owner October 18, 2024 07:30
Copy link

github-actions bot commented Oct 18, 2024

Manual Tests

πŸ’š Manual testing by @dzolt-4chain resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 46.13%. Comparing base (bbd1b05) to head (d3615d0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #747   +/-   ##
=======================================
  Coverage   46.13%   46.13%           
=======================================
  Files         328      328           
  Lines       16700    16700           
=======================================
  Hits         7705     7705           
  Misses       8421     8421           
  Partials      574      574           
Flag Coverage Ξ”
unittests 46.13% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update bbd1b05...d3615d0. Read the comment docs.

@dorzepowski dorzepowski added the regression-tests Runs regression tests label Oct 18, 2024
Co-authored-by: chris-4chain <152964795+chris-4chain@users.noreply.github.com>
@dzolt-4chain dzolt-4chain added the tested PR was tested by a team member label Oct 18, 2024
@dorzepowski dorzepowski merged commit 77011ac into main Oct 18, 2024
26 checks passed
@dorzepowski dorzepowski deleted the ci-aws-ecr-support branch October 18, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-tests Runs regression tests tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants