Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-1345): get webhooks #835

Merged
merged 5 commits into from
Jan 3, 2025
Merged

Conversation

chris-4chain
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@chris-4chain chris-4chain requested a review from a team as a code owner January 2, 2025 08:52
Copy link

github-actions bot commented Jan 2, 2025

Manual Tests

πŸ’š Manual testing by @wregulski resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 63.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 46.03%. Comparing base (ee07ac5) to head (42d30cf).

Files with missing lines Patch % Lines
actions/admin/webhooks.go 63.63% 3 Missing and 1 partial ⚠️
engine/client.go 25.00% 2 Missing and 1 partial ⚠️
engine/datastore/sql.go 62.50% 2 Missing and 1 partial ⚠️
actions/admin/webhooks_old.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
+ Coverage   45.92%   46.03%   +0.11%     
==========================================
  Files         371      371              
  Lines       17856    17881      +25     
==========================================
+ Hits         8200     8232      +32     
+ Misses       9047     9033      -14     
- Partials      609      616       +7     
Flag Coverage Ξ”
unittests 46.03% <63.33%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
actions/admin/routes.go 100.00% <100.00%> (ΓΈ)
docs/docs.go 0.00% <ΓΈ> (ΓΈ)
engine/testabilities/fixture_configopts.go 100.00% <100.00%> (ΓΈ)
actions/admin/webhooks_old.go 0.00% <0.00%> (ΓΈ)
engine/client.go 53.28% <25.00%> (-0.34%) ⬇️
engine/datastore/sql.go 25.71% <62.50%> (+1.88%) ⬆️
actions/admin/webhooks.go 44.44% <63.63%> (+44.44%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update ee07ac5...42d30cf. Read the comment docs.

@wregulski wregulski added the tested PR was tested by a team member label Jan 3, 2025
@chris-4chain chris-4chain merged commit 993421a into main Jan 3, 2025
13 checks passed
@chris-4chain chris-4chain deleted the feat/SPV-1345-get-webhooks branch January 3, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants