Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(SPV-1303): update go client version client in regression tests. #840

Conversation

mgosek-4chain
Copy link
Contributor

@mgosek-4chain mgosek-4chain commented Jan 8, 2025

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@mgosek-4chain mgosek-4chain requested a review from a team as a code owner January 8, 2025 10:28
Copy link

github-actions bot commented Jan 8, 2025

Manual Tests

πŸ’š Manual testing by @dzolt-4chain resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 46.16%. Comparing base (e8ad228) to head (ec36dc8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #840      +/-   ##
==========================================
+ Coverage   46.13%   46.16%   +0.03%     
==========================================
  Files         373      373              
  Lines       17928    17928              
==========================================
+ Hits         8271     8277       +6     
+ Misses       9031     9027       -4     
+ Partials      626      624       -2     
Flag Coverage Ξ”
unittests 46.16% <ΓΈ> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update e8ad228...ec36dc8. Read the comment docs.

@mgosek-4chain mgosek-4chain added the regression-tests Runs regression tests label Jan 8, 2025
@mgosek-4chain mgosek-4chain added regression-tests Runs regression tests and removed regression-tests Runs regression tests labels Jan 9, 2025
@dzolt-4chain dzolt-4chain added the tested PR was tested by a team member label Jan 9, 2025
@mgosek-4chain mgosek-4chain merged commit d8a633c into main Jan 9, 2025
24 of 26 checks passed
@mgosek-4chain mgosek-4chain deleted the refactor/SPV-1303-update-go-client-version-in-regression-tests branch January 9, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-tests Runs regression tests tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants