Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-1341): change delete paymail endpoint to be more restful #854

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

dzolt-4chain
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@dzolt-4chain dzolt-4chain requested a review from a team as a code owner January 16, 2025 15:26
Copy link

github-actions bot commented Jan 16, 2025

Manual Tests

πŸ’š Manual testing by @jakubmkowalski resulted in success.

@dzolt-4chain dzolt-4chain added the regression-tests Runs regression tests label Jan 16, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.

Project coverage is 46.58%. Comparing base (bd6d183) to head (132c927).

Files with missing lines Patch % Lines
engine/action_paymails.go 0.00% 17 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
- Coverage   46.60%   46.58%   -0.02%     
==========================================
  Files         390      390              
  Lines       18514    18524      +10     
==========================================
+ Hits         8629     8630       +1     
- Misses       9193     9204      +11     
+ Partials      692      690       -2     
Flag Coverage Ξ”
unittests 46.58% <10.52%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
actions/admin/paymail_addresses.go 61.00% <100.00%> (+4.92%) ⬆️
docs/docs.go 100.00% <ΓΈ> (ΓΈ)
engine/action_paymails.go 41.87% <0.00%> (-4.98%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update bd6d183...132c927. Read the comment docs.

engine/action_paymails_test.go Outdated Show resolved Hide resolved
@jakubmkowalski jakubmkowalski added regression-tests Runs regression tests tested PR was tested by a team member and removed regression-tests Runs regression tests labels Jan 17, 2025
@dzolt-4chain dzolt-4chain merged commit b06ac5a into main Jan 20, 2025
23 of 26 checks passed
@dzolt-4chain dzolt-4chain deleted the feat/SPV-1341/fix_delete_endpoints branch January 20, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-tests Runs regression tests tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants