feature : joining a team #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MamboBryan
force-pushed
the
mambo/feature/team-join
branch
from
db01f65 to
84f5a45
Compare
MamboBryan
requested review from
kibettheophilus,
janewaitara and
bensalcie
as code owners
...es-sources/remote/src/main/kotlin/com/bizilabs/streeek/lib/remote/helpers/SupabaseHelpers.kt
Outdated
Show resolved
Hide resolved
janewaitara
reviewed
Jan 21, 2025
There was a problem hiding this comment.
@MamboBryan Great job 👏. Just a few things I have noted:
| Discussion Points | Video |
|---|---|
| - There is a visible spacer on Team list screen that we can do away with. - There are 2 loading components. I'm thinking one is for state Loading and the second is the swipe to refresh. What do you think about that? - Both the Join public teams and the team code have the same header to join team. On the Team code one, I'm wondering whether navigating back to the public teams screen is better than the listing screen. @MamboBryan @kibettheophilus What are your thoughts here? |
Join_team.mov |
janewaitara
reviewed
Jan 21, 2025
...main/kotlin/com/bizilabs/streeek/lib/remote/sources/team/requests/TeamRequestRemoteSource.kt
Outdated
Show resolved
Hide resolved
As for the last point in this review, I'm yet to find a way to not show both of them together. Will look into it. |
janewaitara
reviewed
Jan 22, 2025
modules-features/join/src/main/java/com/bizilabs/streeek/feature/join/JoinScreen.kt
Outdated
Show resolved
Hide resolved
janewaitara
approved these changes
Jan 22, 2025
kibettheophilus
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Status
Checks
./gradlew buildor build and it passed successfully./gradlew checkor tests and all have passed successfullyPrevious Behaviour
None
Current Behaviour
None
Intended Behaviour
None
Closes Issues
closes #140
Notes
None
Screenshot
None