Skip to content

Commit

Permalink
Split common serialization test into test cases
Browse files Browse the repository at this point in the history
  • Loading branch information
@blairconrad
blairconrad committed Jun 22, 2020
1 parent bf16b43 commit eb4746d
Show file tree
Hide file tree
Showing 2 changed files with 216 additions and 52 deletions.
264 changes: 212 additions & 52 deletions tests/Acceptance/TypeSerializationTestBase.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,27 +2,40 @@ namespace SelfInitializingFakes.Tests.Acceptance
{
using System;
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.Linq;
using System.Reflection;
using System.Threading.Tasks;

using FluentAssertions;
using SelfInitializingFakes.Tests.Acceptance.Helpers;
using Xbehave;
using Xunit;

public abstract class TypeSerializationTestBase
{
/// <summary>Discover the names of common test cases for <see cref="SerializeCommonCalls(string, IRecordedCallRepository)" /></summary>
/// <remarks>Returns names, even though it's more work to reconsitite the test, because it makes the step names shorter in failure output.</remarks>
public static IEnumerable<object[]> TestCases()
{
return typeof(TypeSerializationTestBase).GetNestedTypes(BindingFlags.NonPublic)
#if FRAMEWORK_TYPE_LACKS_ISABSTRACT
.Where(t => !t.GetTypeInfo().IsAbstract)
#else
.Where(t => !t.IsAbstract)
#endif
.Where(t => typeof(TestCase).IsAssignableFrom(t))
.Select(t => new object[] { t.Name });
}

[MemberData(nameof(TestCases))]
[Scenario]
public void SerializeCommonCalls(
IRecordedCallRepository repository,
int voidMethodOutInteger,
DateTime voidMethodRefDateTime,
Lazy<int> lazyIntMethodResult,
Lazy<string> lazyStringMethodResult,
Lazy<int> lazyOutResult,
Task taskResult,
Task<int> taskIntResult,
Lazy<Task<int>> lazyTaskIntResult,
Task<Lazy<int>> taskLazyIntResult)
public void SerializeCommonCalls(string testName, IRecordedCallRepository repository)
{
var testCase = (TestCase)Activator.CreateInstance(
typeof(TypeSerializationTestBase).GetNestedTypes(BindingFlags.NonPublic)
.First(t => t.Name == testName));

"Given a recorded call repository"
.x(() => repository = this.CreateRepository());

Expand All @@ -31,18 +44,8 @@ public void SerializeCommonCalls(
{
using (var fakeService = SelfInitializingFake<ISampleService>.For(() => new SampleService(), repository))
{
DateTime discardDateTime = DateTime.MaxValue;

var fake = fakeService.Object;

fake.VoidMethod("firstCallKey", out _, ref discardDateTime);
_ = fake.LazyIntReturningMethod();
_ = fake.LazyStringReturningMethod();
fake.MethodWithLazyOut(out _);
_ = fake.TaskReturningMethod();
_ = fake.TaskIntReturningMethod();
_ = fake.LazyTaskIntReturningMethod();
_ = fake.TaskLazyIntReturningMethod();
testCase.Record(fake);
}
});

Expand All @@ -52,50 +55,207 @@ public void SerializeCommonCalls(
using (var playbackFakeService = SelfInitializingFake<ISampleService>.For(UnusedFactory, repository))
{
var fake = playbackFakeService.Object;

fake.VoidMethod("firstCallKey", out voidMethodOutInteger, ref voidMethodRefDateTime);
lazyIntMethodResult = fake.LazyIntReturningMethod();
lazyStringMethodResult = fake.LazyStringReturningMethod();
fake.MethodWithLazyOut(out lazyOutResult);
taskResult = fake.TaskReturningMethod();
taskIntResult = fake.TaskIntReturningMethod();
lazyTaskIntResult = fake.LazyTaskIntReturningMethod();
taskLazyIntResult = fake.TaskLazyIntReturningMethod();
testCase.Playback(fake);
}
});

"Then the playback fake returns the recorded out and ref parameters and results"
.x(() =>
{
voidMethodOutInteger.Should().Be(17);
voidMethodRefDateTime.Should().Be(new DateTime(2017, 1, 24));
testCase.Verify();
});
}

lazyIntMethodResult.IsValueCreated.Should().BeFalse();
lazyIntMethodResult.Value.Should().Be(3);
protected static ISampleService UnusedFactory() => null!;

lazyStringMethodResult.IsValueCreated.Should().BeFalse();
lazyStringMethodResult.Value.Should().Be("three");
protected abstract IRecordedCallRepository CreateRepository();

lazyOutResult.IsValueCreated.Should().BeFalse();
lazyOutResult.Value.Should().Be(-14);
protected abstract class TestCase
{
public abstract void Record(ISampleService service);

taskResult.IsCompleted.Should().BeTrue();
public abstract void Playback(ISampleService service);

taskIntResult.IsCompleted.Should().BeTrue();
taskIntResult.Result.Should().Be(5);
public abstract void Verify();
}

lazyTaskIntResult.IsValueCreated.Should().BeFalse();
lazyTaskIntResult.Value.IsCompleted.Should().BeTrue();
lazyTaskIntResult.Value.Result.Should().Be(19);
[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Required for testing.")]
private class MethodWithOutIntegerAndRefDateTime : TestCase
{
private int voidMethodOutInteger;
private DateTime voidMethodRefDateTime;

taskLazyIntResult.IsCompleted.Should().BeTrue();
taskLazyIntResult.Result.IsValueCreated.Should().BeFalse();
taskLazyIntResult.Result.Value.Should().Be(18);
});
public override void Record(ISampleService service)
{
DateTime discardDateTime = DateTime.MinValue;
service.VoidMethod("firstCallKey", out _, ref discardDateTime);
}

public override void Playback(ISampleService service)
{
service.VoidMethod("firstCallKey", out this.voidMethodOutInteger, ref this.voidMethodRefDateTime);
}

public override void Verify()
{
this.voidMethodOutInteger.Should().Be(17);
this.voidMethodRefDateTime.Should().Be(new DateTime(2017, 1, 24));
}
}

protected static ISampleService UnusedFactory() => null!;
[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Required for testing.")]
private class MethodThatReturnsLazyInt : TestCase
{
private Lazy<int>? result;

protected abstract IRecordedCallRepository CreateRepository();
public override void Record(ISampleService service)
{
service.LazyIntReturningMethod();
}

public override void Playback(ISampleService service)
{
this.result = service.LazyIntReturningMethod();
}

public override void Verify()
{
this.result!.IsValueCreated.Should().BeFalse();
this.result!.Value.Should().Be(3);
}
}

[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Required for testing.")]
private class MethodThatReturnsLazyString : TestCase
{
private Lazy<string>? result;

public override void Record(ISampleService service)
{
service.LazyStringReturningMethod();
}

public override void Playback(ISampleService service)
{
this.result = service.LazyStringReturningMethod();
}

public override void Verify()
{
this.result!.IsValueCreated.Should().BeFalse();
this.result!.Value.Should().Be("three");
}
}

[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Required for testing.")]
private class MethodWithOutLazyInt : TestCase
{
private Lazy<int>? lazyInt;

public override void Record(ISampleService service)
{
service.MethodWithLazyOut(out _);
}

public override void Playback(ISampleService service)
{
service.MethodWithLazyOut(out this.lazyInt);
}

public override void Verify()
{
this.lazyInt!.IsValueCreated.Should().BeFalse();
this.lazyInt!.Value.Should().Be(-14);
}
}

[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Required for testing.")]
private class MethodThatReturnsTask : TestCase
{
private Task? result;

public override void Record(ISampleService service)
{
service.TaskReturningMethod();
}

public override void Playback(ISampleService service)
{
this.result = service.TaskReturningMethod();
}

public override void Verify()
{
this.result!.IsCompleted.Should().BeTrue();
}
}

[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Required for testing.")]
private class MethodThatReturnsTaskInt : TestCase
{
private Task<int>? result;

public override void Record(ISampleService service)
{
service.TaskIntReturningMethod();
}

public override void Playback(ISampleService service)
{
this.result = service.TaskIntReturningMethod();
}

public override void Verify()
{
this.result!.IsCompleted.Should().BeTrue();
this.result!.Result.Should().Be(5);
}
}

[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Required for testing.")]
private class MethodThatReturnsLazyTaskInt : TestCase
{
private Lazy<Task<int>>? result;

public override void Record(ISampleService service)
{
service.LazyTaskIntReturningMethod();
}

public override void Playback(ISampleService service)
{
this.result = service.LazyTaskIntReturningMethod();
}

public override void Verify()
{
this.result!.IsValueCreated.Should().BeFalse();
this.result!.Value.IsCompleted.Should().BeTrue();
this.result!.Value.Result.Should().Be(19);
}
}

[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Required for testing.")]
private class MethodThatReturnsTaskLazyInt : TestCase
{
private Task<Lazy<int>>? result;

public override void Record(ISampleService service)
{
service.TaskLazyIntReturningMethod();
}

public override void Playback(ISampleService service)
{
this.result = service.TaskLazyIntReturningMethod();
}

public override void Verify()
{
this.result!.IsCompleted.Should().BeTrue();
this.result!.Result.IsValueCreated.Should().BeFalse();
this.result!.Result.Value.Should().Be(18);
}
}
}
}
}
4 changes: 4 additions & 0 deletions tests/Directory.Build.props
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,8 @@
<Compile Remove="..\Acceptance\BinarySerialization.cs" />
</ItemGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'netcoreapp1.0' ">
<DefineConstants>$(DefineConstants);FRAMEWORK_TYPE_LACKS_ISABSTRACT</DefineConstants>
</PropertyGroup>

</Project>

0 comments on commit eb4746d

Please sign in to comment.