-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overlay, initial preset and selecting backward ability #63
base: master
Are you sure you want to change the base?
Conversation
Hey @blibliandirdjunaedi! Would you mind having a look at your Travis build settings? It looks like it's throwing a setup error:
|
@@ -18,7 +18,7 @@ | |||
<ul v-for="r in 6" :class="[s.days]" :key="r"> | |||
<li :class="[{[s.daysSelected]: isDateSelected(r, i, 'first', startMonthDay, endMonthDate), | |||
[s.daysInRange]: isDateInRange(r, i, 'first', startMonthDay, endMonthDate), | |||
[s.dateDisabled]: isDateDisabled(r, i, startMonthDay, endMonthDate)}]" v-for="i in numOfDays" :key="i" v-html="getDayCell(r, i, startMonthDay, endMonthDate)" | |||
[s.dateDisabled]: isDateDisabled(r, i, startMonthDay, endMonthDate), [s.dateAfterMax]: isDateAfterMax(r, i, 'first', startNextMonthDay, endNextMonthDate)}]" v-for="i in numOfDays" :key="i" v-html="getDayCell(r, i, startMonthDay, endMonthDate)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AaronThornton00 thank you for the improvements 👍
I noticed there is a bug here, it should be isDateAfterMax(r, i, 'first', startMonthDay, endMonthDate)
We'd love to move this along @okoriko , but it looks like we're going to be blocked by your CI requirements on this repo. While our branch might have some issues, it looks like master does too. If you could (please <3) get master passing, we'll try get this branch green including that bugfix. |
Hey @okoriko , is CI still a requirement for merging on this repository? I haven't seen changes to master in a loooooooong time. Has bliblidotcom abandoned development on this project? |
@heymatthew I'm not the owner, nor a contributor on this repo, I'm afraid I can't help you with this 😞 |
Sorry @okoriko , thanks for the code review I wasn't looking to offend. My bigger worry is that we can't communicate with upstream and I thought that your code review indicated that you might be able to change that. There's clearly an appetite for this plugin to be maintained. That two non core devs are reviewing and trying to contribute upstream is pretty clear evidence that this project has legs. I've raised #74 to try gain the attention of the project owners. Lets see if they respond-- perhaps we can upgrade you to a contributor or fork the project and merge people's PRs :). |
This PR adds the following behaviour:
Keen for any feedback, be great to see this merged.