feat: add a test and RBAC common code #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryan-Gordon
commented
Jan 12, 2020
| console.log(`[DEBUG] <Test #1> response: ${response}`); | ||
| assert.ok(response); | ||
|
|
||
| // const tx_hash2 = await virusContract.addVaccine(competitor,"BCG",validIpfsHash); |
There was a problem hiding this comment.
Uncommenting this will make the test fail with Error: invalid address
Ryan-Gordon
commented
Jan 12, 2020
| @@ -0,0 +1,41 @@ | |||
| pragma solidity 0.5.4; | |||
There was a problem hiding this comment.
Tronbox only has support for certain solidity versions. I can bump this to 0.5.8 now and higher in the future.
PaddyMc
approved these changes
Jan 21, 2020
|
Sorry for the delay in reviewing here ! Awesome work man 💎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a common contract for authentication which Virus inherits from.
Note on the tests: they seem to pass without explicitly adding the admin. The second address from accounts generates an invalid address error.