Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prawn-table support #44

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

prawn-table support #44

wants to merge 7 commits into from

Conversation

blocknotes
Copy link
Owner

@blocknotes blocknotes commented Jul 9, 2022 •
edited
Loading

Related to #34

@blocknotes blocknotes self-assigned this Jul 9, 2022
github-actions[bot]
github-actions bot reviewed Jul 9, 2022
View reviewed changes
lib/prawn_html/tag.rb Outdated Show resolved Hide resolved
lib/prawn_html/tag.rb Outdated Show resolved Hide resolved
lib/prawn_html/tag.rb Outdated Show resolved Hide resolved
lib/prawn_html/tag.rb Outdated Show resolved Hide resolved
@blocknotes blocknotes force-pushed the support-for-prawn-table branch from 95f657e to 0f6858d Compare July 9, 2022 07:48
@blocknotes blocknotes changed the title Support for prawn table prawn-table support Jul 9, 2022
@blocknotes blocknotes force-pushed the support-for-prawn-table branch from 0f6858d to 3620a04 Compare July 9, 2022 10:02
@julianrubisch
Copy link

Ha! I was just starting to develop this, but you beat me to it 🙈

Let me know if you need help putting this through its paces.

@blocknotes
Copy link
Owner Author

blocknotes commented Sep 5, 2022 •
edited
Loading

Ha! I was just starting to develop this, but you beat me to it 🙈
Let me know if you need help putting this through its paces.

Hey @julianrubisch.
I'm sorry to reply so late :)
Thanks for your contribution about the table closing tag.

I'm still evaluating the approach of this PR BTW.
The integration with prawn-table works but it's not as flexible as I would expect.

I'm going to try to implement my own version of table and see how it works.

@julianrubisch
Copy link

gotcha, I can see why :-)

I'll keep playing around on my fork as I need some type of table support, however rudimentary, at the moment.

@blocknotes
Copy link
Owner Author

I'll keep playing around on my fork as I need some type of table support, however rudimentary, at the moment.

Ok, feel free to share when you have something to show. I'm curious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@blocknotes blocknotes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blocknotes @julianrubisch