Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2pc remtran over cdb2api #4848

Closed
wants to merge 7 commits into from
Closed

Conversation

dorinhogea
Copy link
Contributor

Branched off #4777, removes remtran protocol when 2pc is enabled.
To be merged after the dependency is merged.

…acy remtran plugin.

Currently it supports non-2pc transactions and socksql transaction isolation.
It provides protocol versioning and solves the stale schema change issue, which the previous implementation did not support.

PR adds a fdb compatibility testcase to check for ability to execute cross-cluster queries and writes with older and newer protocol
versions.

The new implementation eliminates some of the fragile synchronization between read and write remote cursors in the previous implementation,
by running the write statements remotely (push mode extended to writes).

Signed-off-by: Dorin Hogea <dhogea@bloomberg.net>
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.

@dorinhogea
Copy link
Contributor Author

/plugin-branch remtrancdb2api

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.

Signed-off-by: Dorin Hogea <dhogea@bloomberg.net>
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 9/588 tests failed ⚠.

The first 10 failing tests are:
vutf8_dbstore_off_osql_odh_blob_generated [setup failure]
phys_rep_tiered_nosource_generated
analyze_partial_index_off_generated
snap_ha_retry_newsi_generated
fdb_compat_rte_connect_generated
fdb_compat
simple_remsql_whitelist_generated
tunables
auth

Signed-off-by: Dorin Hogea <dhogea@bloomberg.net>
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 22/588 tests failed ⚠.

The first 10 failing tests are:
sc_lotsoftables [setup failure]
sc_transactional_rowlocks_generated
phys_rep_tiered
simple_timepart_reptimeout_generated
simple_timepart
commit_delay_on_copy
simple_ssl
snap_ha_retry_newsi_generated
simple_remsql_whitelist_generated
yast_stat4scan_generated

@dorinhogea
Copy link
Contributor Author

the collapsed and rebased code was resubmitted here #4917, as the base PR was merged.

@dorinhogea dorinhogea closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants