Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set generation from ckp-logs 8.0 #4908

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

markhannum
Copy link
Contributor

@markhannum markhannum commented Dec 14, 2024

Not writing rep-gen transaction records from full-recovery opened up situations where a node coming up would be able to see the most recently written generation only from checkpoint records. Because of this bug, it would then start to emit records at a lower generation than had been previously seen.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 7/563 tests failed ⚠.

The first 10 failing tests are:
phys_rep_perf
logarchive
comdb2sys_queueodh_generated
comdb2sys_pagesize_generated
comdb2sys
sc_downgrade
truncatesc_offline_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 7/563 tests failed ⚠.

The first 10 failing tests are:
analyze_fastinit_race
phys_rep_perf
logarchive
comdb2sys_queueodh_generated
comdb2sys_pagesize_generated
comdb2sys
truncatesc_offline_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 8/563 tests failed ⚠.

The first 10 failing tests are:
analyze_fastinit_race
phys_rep_perf
sc_resume2
logarchive
comdb2sys_queueodh_generated
comdb2sys_pagesize_generated
comdb2sys
truncatesc_offline_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

@akshatsikarwar akshatsikarwar changed the title Set generation from ckp-logs Set generation from ckp-logs 8.0 Dec 16, 2024
@markhannum markhannum force-pushed the setup_failure_fix_8 branch 4 times, most recently from 6901451 to 32f1fda Compare December 23, 2024 14:55
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 8/565 tests failed ⚠.

The first 10 failing tests are:
phys_rep_perf
pglogs_seqnum
nogen_full_recovery_disable_generated
online_compaction
analyze_partial_index_off_generated
logarchive
tunables
truncatesc_offline_generated

@markhannum markhannum force-pushed the setup_failure_fix_8 branch 2 times, most recently from 54d2b38 to e0c422b Compare December 26, 2024 16:10
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 4/567 tests failed ⚠.

The first 10 failing tests are:
phys_rep_perf
logarchive
tunables
truncatesc_offline_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 5/567 tests failed ⚠.

The first 10 failing tests are:
logfill_logput_window_generated
phys_rep_perf
sc_parallel_logicalsc_generated
logarchive
truncatesc_offline_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 6/567 tests failed ⚠.

The first 10 failing tests are:
analyze_fastinit_race
phys_rep_perf
queuedb_rollover
nogen_full_recovery_disable_generated
nogen_full_recovery_ckpbug_generated
truncatesc_offline_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 3/567 tests failed ⚠.

The first 10 failing tests are:
lostwrite [setup failure]
phys_rep_perf
truncatesc_offline_generated

@markhannum markhannum force-pushed the setup_failure_fix_8 branch 2 times, most recently from 4bce9d1 to 070ca61 Compare January 2, 2025 14:25
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 3/568 tests failed ⚠.

The first 10 failing tests are:
phys_rep_perf
phys_rep_tiered_firstfile_generated
truncatesc_offline_generated

@markhannum markhannum force-pushed the setup_failure_fix_8 branch from 5d7e4ca to 89a526a Compare January 4, 2025 20:12
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 5/566 tests failed ⚠.

The first 10 failing tests are:
phys_rep_perf
queuedb_rollover_noroll1_generated
analyze
sc_datacopy_logicalsc_generated
truncatesc_offline_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 2/566 tests failed ⚠.

The first 10 failing tests are:
phys_rep_perf
truncatesc_offline_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 3/566 tests failed ⚠.

The first 10 failing tests are:
lostwrite [setup failure]
phys_rep_perf
truncatesc_offline_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 3/566 tests failed ⚠.

The first 10 failing tests are:
phys_rep_perf
lostwrite
truncatesc_offline_generated

@markhannum markhannum force-pushed the setup_failure_fix_8 branch from 89a526a to cca4754 Compare January 9, 2025 13:18
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 3/566 tests failed ⚠.

The first 10 failing tests are:
phys_rep_perf
lostwrite
truncatesc_offline_generated

@markhannum markhannum force-pushed the setup_failure_fix_8 branch 3 times, most recently from 96ecf94 to 7bd7f7b Compare January 18, 2025 01:06
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 5/567 tests failed ⚠.

The first 10 failing tests are:
sc_truncate_lockorder_generated
sc_transactional_rowlocks_generated
phys_rep_perf
nogen_full_recovery
truncatesc_offline_generated

aakash10292
aakash10292 previously approved these changes Jan 21, 2025
Copy link
Contributor

@aakash10292 aakash10292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walked through changes with Mark. LGTM

Emit all election messages on LOGMSG_USER
Verify commit & ckp records after setup

Signed-off-by: Mark Hannum <mhannum72@gmail.com>
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 4/567 tests failed ⚠.

The first 10 failing tests are:
osql_cleanup
phys_rep_perf
sc_downgrade
truncatesc_offline_generated

@markhannum markhannum merged commit 6c89f60 into bloomberg:8.0 Jan 22, 2025
1 check passed
@markhannum markhannum deleted the setup_failure_fix_8 branch January 22, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants