Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit can randomly calls exit from main alongside clean_exit_thd #4952

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

mohitkhullar
Copy link
Contributor

@mohitkhullar mohitkhullar commented Jan 9, 2025

Some destroy functions are not called in that case

gbl_exit flag is set before thread is registered as THRTYPE_CLEANEXIT thread

Signed-off-by: mohitkhullar <mkhullar1@bloomberg.net>
@mohitkhullar mohitkhullar requested a review from mponomar January 9, 2025 19:12
@mohitkhullar mohitkhullar changed the title exit can randomly call exit from main alongside clean_exit exit can randomly calls exit from main alongside clean_exit_thd Jan 9, 2025
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 135/597 tests failed ⚠.

The first 10 failing tests are:
vutf8_rowlocks_off_osql_odh_blob_generated [setup failure]
misstable_remsql [setup failure]
fdb_push_rte_connect_generated [setup failure]
phys_rep_perf
printlog
comdb2sys_queueodh_generated
comdb2sys_pagesize_generated
comdb2sys
snapisol_partial_index_off_generated
snap_ha_retry_newsi_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 0/595 tests failed ⚠.

@akshatsikarwar akshatsikarwar merged commit faa452e into bloomberg:main Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants