-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(filter): handle 'tag only' fields #53
Conversation
Ah my man. This is exactly how I imagined it, a while back. With the new part and context fields. |
Tested and working locally. Ready for wider review. |
@@ -40,6 +44,9 @@ func DefaultNodeHandler(_, currentRef, nextRef string, opts Options) (string, er | |||
return currentRef, err | |||
} | |||
|
|||
if opts.Part == "tag" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure how to handle the tag in this situation.
One way could be to have the digest as a seperate part to select from. Then we also need a way to combine parts into a single output field.
Or everything after the image is considered the tag or identifier how the container package calls it.
On top of that, the built in decoder actuall generate <tag>@<digest>
identifiers. This is technically not correct. Registiries will ignore the tag but its nice for informational purposes.
I will merge this now. I think it can be as is, and I will add other parts called digest and identifier or something. Its actually already all there, I just need to switch on opts.part. |
thanks for the work :) |
Add ability to update fields that contain only an image tag, not a full image ref.
#19