Update/ecommerce to 1.3.33 #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: NPM(deps): Bump @wordpress/element from 5.35.0 to 6.1.0 NPM(deps): Bump @wordpress/html-entities from 3.58.0 to 4.1.0 Composer Dev(deps-dev): Bump wp-phpunit/wp-phpunit from 6.5.3 to 6.5.4 NPM(deps): Bump @wordpress/dom-ready from 3.58.0 to 4.1.0 NPM Dev(deps-dev): Bump @testing-library/cypress from 10.0.1 to 10.0.2 # Conflicts: # composer.lock
8 tasks
3 failed tests on run #8753 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Coming Soon > Launching launches site |
Test Replay
Screenshots
Video
|
|
vendor/newfold-labs/wp-module-deactivation/tests/cypress/integration/deactivation-survey.cy.js • 2 failed tests
Review all test suite changes for PR #1128 ↗︎
6 failed tests on run #8750 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Coming Soon > Launching launches site |
Test Replay
Screenshots
Video
|
|
vendor/newfold-labs/wp-module-deactivation/tests/cypress/integration/deactivation-survey.cy.js • 2 failed tests
vendor/newfold-labs/wp-module-marketplace/tests/cypress/integration/product-page.cy.js • 3 failed tests
Review all test suite changes for PR #1128 ↗︎
|
Noting that the ecommerce tests look good but coming soon, deactivation survey, and marketplace product page tests fail with this update. |
* develop: Fix eslint issue `socialMediaAccounts.js` Bump marketplace module to `2.3.0` add `nfd-overflow-clip` to marketplace page wrapper to allow sticky scrolling Marketplace page overflow hidden Pass `useNavigate` hook to the marketplace module components Pass product page error state strings Pass react router `useMatch` hook to the marketplace module # Conflicts: # composer.lock
wpalani
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
See #1117 - this updates the branch name so tests will run and merges latest develop into the branch.
Type of Change
Checklist
Further comments