Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch Button | Calling comingSoonAdminbarToggle on update of comingsoon state #1141

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

ramyakrishnai
Copy link
Contributor

Proposed changes

Jira: https://jira.newfold.com/browse/PRESS4-547

Screen.Recording.2024-06-24.at.12.19.31.PM.mov

calling comingSoonAdminbarToggle on update of comingsoon

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

cypress bot commented Jun 24, 2024

Passing run #8928 ↗︎

0 389 60 0 Flakiness 0

Details:

linting fixes
Project: Bluehost Brand Plugin Commit: fd479c5caa
Status: Passed Duration: 24:24 💡
Started: Jun 26, 2024 11:28 AM Ended: Jun 26, 2024 11:53 AM

Review all test suite changes for PR #1141 ↗︎

Copy link

cypress bot commented Jun 24, 2024

Passing run #8923 ↗︎

0 389 60 0 Flakiness 0

Details:

Merge e97f8ad into 65b7e31...
Project: Bluehost Brand Plugin Commit: 5986ad6585 ℹ️
Status: Passed Duration: 24:19 💡
Started: Jun 24, 2024 7:14 AM Ended: Jun 24, 2024 7:39 AM

Review all test suite changes for PR #1141 ↗︎

Copy link
Member

@wpalani wpalani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramyakrishnai Is there a test written for this already? I can't seem to find any. If we don't have one, do you mind writing a test for this?

Copy link
Member

@wpalani wpalani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found the test in this PR on the marketplace module: newfold-labs/wp-module-ecommerce#330

Approved.

@wpalani wpalani merged commit 505a017 into develop Jun 26, 2024
4 checks passed
@wpalani wpalani deleted the fix/coming-soon branch June 26, 2024 16:57
@cypress cypress bot mentioned this pull request Jun 26, 2024
8 tasks
@circlecube circlecube added this to the June 26 Release milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants