-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch Button | Calling comingSoonAdminbarToggle on update of comingsoon state #1141
Conversation
Passing run #8928 ↗︎
Details:
Review all test suite changes for PR #1141 ↗︎ |
Passing run #8923 ↗︎
Details:
Review all test suite changes for PR #1141 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ramyakrishnai Is there a test written for this already? I can't seem to find any. If we don't have one, do you mind writing a test for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just found the test in this PR on the marketplace module: newfold-labs/wp-module-ecommerce#330
Approved.
Proposed changes
Jira: https://jira.newfold.com/browse/PRESS4-547
Screen.Recording.2024-06-24.at.12.19.31.PM.mov
calling comingSoonAdminbarToggle on update of comingsoon
Type of Change
Checklist
Further comments