Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runtime to npmjs #1506

Merged
merged 9 commits into from
Jan 16, 2025
Merged

Update runtime to npmjs #1506

merged 9 commits into from
Jan 16, 2025

Conversation

circlecube
Copy link
Member

Proposed changes

This updates the runtime package to the newly hosted npmjs build. Migrating from github package to npmjs package will remove the token requirement and allow workflows to perform more often as expected. Currently, they often fail due to no token being found (for dependabot and in forked repos outside the newfold-labs org).

This updates the package and its imports.

See PRESS10-73 and PRESS10-63 for more details.

Also, see runtime package updates for this change:

And a similar PR on the e-commerce module doing the same thing:

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube self-assigned this Jan 8, 2025
@circlecube circlecube added this to the January 15, 2025 Release milestone Jan 8, 2025
Copy link

cypress bot commented Jan 8, 2025

Bluehost Brand Plugin    Run #12606

Run Properties:  status check passed Passed #12606  •  git commit 763eeddbd5: update remaining modules for runtime updates
Project Bluehost Brand Plugin
Branch Review update/runtime-npmjs
Run status status check passed Passed #12606
Run duration 32m 01s
Commit git commit 763eeddbd5: update remaining modules for runtime updates
Committer Evan Mullins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 33
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 407
View all changes introduced in this branch ↗︎

Copy link

cypress bot commented Jan 8, 2025

Bluehost Brand Plugin    Run #12591

Run Properties:  status check failed Failed #12591  •  git commit 27f4f2f7b6 ℹ️: Merge c8bff282c254914a17409c7be1869df7fc98f70a into d25d8826c015e354de0a70b44115...
Project Bluehost Brand Plugin
Branch Review update/runtime-npmjs
Run status status check failed Failed #12591
Run duration 33m 41s
Commit git commit 27f4f2f7b6 ℹ️: Merge c8bff282c254914a17409c7be1869df7fc98f70a into d25d8826c015e354de0a70b44115...
Committer Evan Mullins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 33
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 409
View all changes introduced in this branch ↗︎

Tests for review

Failed  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/ecommerce-coming-soon.cy.js • 1 failed test

View Output Video

Test Artifacts
e-commerce Home Page- Coming soon mode > Verify Site Preview flex and View your site option Test Replay Screenshots Video

@circlecube circlecube changed the base branch from main to develop January 10, 2025 21:41
* develop:
  NPM(deps): Bump @wordpress/icons from 10.14.0 to 10.15.1
  NPM(deps): Bump @wordpress/compose from 7.14.0 to 7.15.1
  Bug fixes patch
  NPM(deps): Bump @wordpress/element from 6.14.0 to 6.15.1
  NPM(deps): Bump @wordpress/i18n from 5.14.0 to 5.15.1
  Bump Performance to 2.3.0
  Composer(deps): Bump newfold-labs/wp-module-global-ctb
  NPM Dev(deps-dev): Bump @wordpress/scripts from 30.7.0 to 30.8.1
  NPM(deps): Bump @wordpress/html-entities from 4.14.0 to 4.15.0
  Tweak: usage of constant BLUEHOST_PLUGIN_DIR
  New: include new burst safety folder

# Conflicts:
#	package-lock.json
roll back wpscripts update
  - Upgrading newfold-labs/wp-module-marketplace (2.4.0 => 2.5.0)
  - Upgrading newfold-labs/wp-module-performance (2.3.2 => 2.4.0)
@circlecube circlecube merged commit 2003678 into develop Jan 16, 2025
3 checks passed
@circlecube circlecube deleted the update/runtime-npmjs branch January 16, 2025 16:58
@circlecube circlecube mentioned this pull request Jan 16, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants