Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix plugin slug in action links filter #966

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

circlecube
Copy link
Member

Proposed changes

These links were already set up in the plugin but the plugin slug was incorrect in the hook so it was never loaded. This fixes that so they display (finally)

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

cypress bot commented Feb 29, 2024

Passing run #7464 ↗︎

0 333 24 0 Flakiness 0

Details:

Merge 3c88bf3 into d01332a...
Project: Bluehost Brand Plugin Commit: da52fa3a16 ℹ️
Status: Passed Duration: 19:15 💡
Started: Feb 29, 2024 6:36 PM Ended: Feb 29, 2024 6:55 PM

Review all test suite changes for PR #966 ↗︎

Copy link

cypress bot commented Feb 29, 2024

Passing run #7465 ↗︎

0 333 24 0 Flakiness 0

Details:

Determine basename from `BLUEHOST_PLUGIN_FILE`
Project: Bluehost Brand Plugin Commit: 7d8868fd38
Status: Passed Duration: 18:57 💡
Started: Feb 29, 2024 7:04 PM Ended: Feb 29, 2024 7:23 PM

Review all test suite changes for PR #966 ↗︎

@circlecube circlecube merged commit 88dbadf into develop Feb 29, 2024
4 checks passed
@circlecube circlecube deleted the fix/plugin-action-links branch February 29, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants