-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out common AD file plugin logic into core writer class, create ADTiffWriter #606
Conversation
@genematx Here are the ophyd async changes that introduce tiff writer support, specifically you can look at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We reviewed the changes interactively with @jwlodek and @RobertSchaffer1, and they make sense to me.
@coretl, if you are happy with the changes, Jakub will rebase the PR branch to resolve the conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some ideas that will remove some of the cast
statements, what do you reckon?
Applied the changes, rebased, and tests are now passing, but for some reason I am having issues running with real hardware. I think I will start a fresh environment on Monday and confirm if I can collect both HDF and TIFF data and read it back via tiled. |
I can see why you've done it, but I would still prefer to pass in the writer instance rather than class into the |
… dataset description" This reverts commit 488d7eb.
This is I think ready for another review pass @coretl , but I need to figure out what is happening with the tests on 3.12... |
@coretl applied your suggestions, I agree it is cleaner this way. Still have a unawaited coro error on 3.12 - need to track that down |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor points now, looks almost done, thanks!
Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
I think this is now ready for a final once over and then merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a skim of this it looks fine. One possibly unused variable...
This now seems to mostly work, at least from the collection side.
The data cannot be read back via tiled at the moment, however, so for now marking as draft, since I may need to edit the docs generated somewhat to account for this. PRs intobluesky
andtiled
have been merged to allow reading back collected TIFF data with this branch.Addresses #595 .
TODO: