ENH: Add data type to sparse #783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielballan
approved these changes
Sep 7, 2024
There was a problem hiding this comment.
I had to think about how this ever worked in the first place! Since we move the data in Arrow IPC format by default, the data types come free. Clearly you are correct: we should be writing down the data type.
Let's merge after some third person has chance to kick the tires and confirm interactively that there are no surprises here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the (dense)
ArrayAdapter, adapters for sparse arrays (e.g.COOAdapter) didn't havedtypeexplicitly stored. This PR adds a new property,data_type, toCOOAdapterand the correspondingCOOStructure; the new property is initialized similarly to how it's done forArrayAdapter, including the possibility to useStructDtypes.The changes are caused by the requirement to specify dtype when exposing the arrays at
/zarr/v2endpoints (see Issue #562 and PR #774).Checklist