Switch from QCombobox to QCheckbox (bool) for FixFirstWordsCapitaliza…

…tion.

src/usdb_syncer/download_options.py

@@ -13,7 +13,7 @@ class TxtOptions:
     encoding: settings.Encoding
     newline: settings.Newline
     fix_linebreaks: settings.FixLinebreaks
-    fix_first_words_capitalization: settings.FixFirstWordsCapitalization
+    fix_first_words_capitalization: bool
     fix_spaces: settings.FixSpaces
 
 

src/usdb_syncer/gui/forms/SettingsDialog.ui

@@ -155,9 +155,9 @@
              </widget>
             </item>
             <item row="3" column="1">
-             <widget class="QComboBox" name="comboBox_fix_first_words_capitalization">
-              <property name="toolTip">
-               <string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;If this setting is enabled, the first word of each line is capitalized.&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
+             <widget class="QCheckBox" name="checkBox_fix_first_words_capitalization">
+              <property name="text">
+               <string/>
               </property>
              </widget>
             </item>

src/usdb_syncer/gui/settings_dialog.py

@@ -48,10 +48,6 @@ def _populate_comboboxes(self) -> None:
             (self.comboBox_encoding, settings.Encoding),
             (self.comboBox_line_endings, settings.Newline),
             (self.comboBox_fix_linebreaks, settings.FixLinebreaks),
-            (
-                self.comboBox_fix_first_words_capitalization,
-                settings.FixFirstWordsCapitalization,
-            ),
             (self.comboBox_fix_spaces, settings.FixSpaces),
             (self.comboBox_cover_max_size, settings.CoverMaxSize),
             (self.comboBox_audio_format, settings.AudioFormat),
@@ -85,10 +81,8 @@ def _load_settings(self) -> None:
         self.comboBox_fix_linebreaks.setCurrentIndex(
             self.comboBox_fix_linebreaks.findData(settings.get_fix_linebreaks())
         )
-        self.comboBox_fix_first_words_capitalization.setCurrentIndex(
-            self.comboBox_fix_first_words_capitalization.findData(
-                settings.get_fix_first_words_capitalization()
-            )
+        self.checkBox_fix_first_words_capitalization.setChecked(
+            settings.get_fix_first_words_capitalization()
         )
         self.comboBox_fix_spaces.setCurrentIndex(
             self.comboBox_fix_spaces.findData(settings.get_fix_spaces())
@@ -161,7 +155,7 @@ def _save_settings(self) -> bool:
         settings.set_newline(self.comboBox_line_endings.currentData())
         settings.set_fix_linebreaks(self.comboBox_fix_linebreaks.currentData())
         settings.set_fix_first_words_capitalization(
-            self.comboBox_fix_first_words_capitalization.currentData()
+            self.checkBox_fix_first_words_capitalization.isChecked()
         )
         settings.set_fix_spaces(self.comboBox_fix_spaces.currentData())
         settings.set_audio(self.groupBox_audio.isChecked())

src/usdb_syncer/settings.py

@@ -159,22 +159,6 @@ def __str__(self) -> str:
                 assert_never(unreachable)
 
 
-class FixFirstWordsCapitalization(Enum):
-    """Supported variants for fixing first words capitalization."""
-
-    DISABLE = 0
-    ENABLE = 1
-
-    def __str__(self) -> str:
-        match self:
-            case FixFirstWordsCapitalization.ENABLE:
-                return "enable"
-            case FixFirstWordsCapitalization.DISABLE:
-                return "disable"
-            case _ as unreachable:
-                assert_never(unreachable)
-
-
 class FixSpaces(Enum):
     """Supported variants for fixing spaces."""
 
@@ -599,13 +583,11 @@ def set_fix_linebreaks(value: FixLinebreaks) -> None:
     set_setting(SettingKey.FIX_LINEBREAKS, value)
 
 
-def get_fix_first_words_capitalization() -> FixFirstWordsCapitalization:
-    return get_setting(
-        SettingKey.FIX_FIRSTWORDSCAPITALIZATION, FixFirstWordsCapitalization.ENABLE
-    )
+def get_fix_first_words_capitalization() -> bool:
+    return get_setting(SettingKey.FIX_FIRSTWORDSCAPITALIZATION, True)
 
 
-def set_fix_first_words_capitalization(value: FixFirstWordsCapitalization) -> None:
+def set_fix_first_words_capitalization(value: bool) -> None:
     set_setting(SettingKey.FIX_FIRSTWORDSCAPITALIZATION, value)
 
 

src/usdb_syncer/song_txt/__init__.py

@@ -10,7 +10,7 @@
 from usdb_syncer import download_options, errors
 from usdb_syncer.logger import Log
 from usdb_syncer.meta_tags import MetaTags
-from usdb_syncer.settings import FixFirstWordsCapitalization, FixLinebreaks, FixSpaces
+from usdb_syncer.settings import FixLinebreaks, FixSpaces
 from usdb_syncer.song_txt.headers import Headers
 from usdb_syncer.song_txt.tracks import Tracks
 
@@ -112,10 +112,7 @@ def fix(self, txt_options: download_options.TxtOptions) -> None:
                     self.notes.fix_linebreaks_yass_style(self.headers.bpm, self.logger)
                 case _ as unreachable:
                     assert_never(unreachable)
-            if (
-                txt_options.fix_first_words_capitalization
-                != FixFirstWordsCapitalization.DISABLE
-            ):
+            if txt_options.fix_first_words_capitalization:
                 self.notes.fix_first_words_capitalization(self.logger)
             if txt_options.fix_spaces != FixSpaces.DISABLE:
                 self.notes.fix_spaces(txt_options.fix_spaces, self.logger)

tests/unit/song_txt/test_notes_parser.py

@@ -5,13 +5,7 @@
 
 from usdb_syncer.download_options import TxtOptions
 from usdb_syncer.logger import get_logger
-from usdb_syncer.settings import (
-    Encoding,
-    FixFirstWordsCapitalization,
-    FixLinebreaks,
-    FixSpaces,
-    Newline,
-)
+from usdb_syncer.settings import Encoding, FixLinebreaks, FixSpaces, Newline
 from usdb_syncer.song_txt import SongTxt
 
 _logger = get_logger(__file__)
@@ -50,7 +44,7 @@ def test_notes_parser_fixes(resource_dir: str) -> None:
                 encoding=Encoding.UTF_8,
                 newline=Newline.CRLF,
                 fix_linebreaks=FixLinebreaks.USDX_STYLE,
-                fix_first_words_capitalization=FixFirstWordsCapitalization.ENABLE,
+                fix_first_words_capitalization=True,
                 fix_spaces=FixSpaces.AFTER,
             )
         )