Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from browser_cookie3 to rookiepy. #306

Merged
merged 5 commits into from
Nov 3, 2024
Merged

Switch from browser_cookie3 to rookiepy. #306

merged 5 commits into from
Nov 3, 2024

Conversation

bohning
Copy link
Owner

@bohning bohning commented Oct 30, 2024

No description provided.

@RumovZ
Copy link
Collaborator

RumovZ commented Nov 3, 2024

I tried some browsers on Windows:

browser_cookie3 rookiepy
Chrome
Firefox ✔️ ✔️
Edge ✔️ (only admin)

So unfortunately, the only improvement is with Edge, provided the user is willing and able to run in admin mode. But at least that's something.

rookiepy has some annoying logging we should get under control before merging.

@bohning
Copy link
Owner Author

bohning commented Nov 3, 2024

Did you try with 0.5.5 (in this branch) or the new 0.5.6?

With 0.5.5, I tried some browsers on Mac:

browser_cookie3 rookiepy
Chrome ✔️
Firefox ✔️ ✔️
Edge ✔️
Safari ✔️ ✔️

So unfortunately, the only improvement is with Edge, provided the user is willing and able to run in admin mode. But at least that's something.

On Mac, it also works for Chrome. And rookiepy seems to be more actively developed.

rookiepy has some annoying logging we should get under control before merging.

Yes.

@bohning bohning merged commit a76a127 into main Nov 3, 2024
1 check passed
@bohning bohning deleted the rookiepy branch November 3, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants