Optional fix for quotation marks #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RumovZ
reviewed
Nov 7, 2024
RumovZ
reviewed
Nov 8, 2024
|
|
||
| marks_total = marks_total + 1 | ||
|
|
||
| return value, marks_total, marks_fixed |
There was a problem hiding this comment.
It's not clear what this function returns. A dataclass or named tuple would be nice.
There was a problem hiding this comment.
Like this?
from typing import NamedTuple
# Define the named tuple class
class ReplacementResult(NamedTuple):
value: str
marks_total: int
marks_fixed: int
|
As the code is becoming more complicated, it's hard to tell if it does the right thing just from looking at it. Some unit tests would be helpful. |
RumovZ
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.