Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding UIB communication content (#2722 improvement) #2733

Merged
merged 24 commits into from
Jun 28, 2024

Conversation

marcobonita
Copy link
Contributor

Content of #2722 + suggested changes

Copy link
Contributor

github-actions bot commented Jun 14, 2024

📝 Check the pages that have been modified

In order to merge this pull request, you need to check your updates with the following url.

🔍 Updated pages

The following pages were updated, please ensure that the display is correct:

Copy link
Contributor

github-actions bot commented Jun 14, 2024

😭 Deploy PR Preview b5c85b8 failed. Build logs

🤖 By surge-preview

@benjaminParisel
Copy link
Contributor

Are you sure about this preview ?
image

marcobonita and others added 2 commits June 19, 2024 08:25
@marcobonita
Copy link
Contributor Author

Are you sure about this preview ? image

Weird, this part is identical to the original file

Copy link
Contributor

@benjaminParisel benjaminParisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me with syntax

modules/ROOT/pages/release-notes.adoc Outdated Show resolved Hide resolved
@benjaminParisel
Copy link
Contributor

⚠️ Waiting for surge issue resolving, to check the preview and then we can merge

@benjaminParisel
Copy link
Contributor

@marcobonita Il y a une erreur dans le buld qui dit ceci:
[06:24:05.040] FATAL (antora): Page alias cannot reference an existing page: 2024.3@bonita:applications:custom-applications-index.adoc (specified as: applications:custom-applications-index.adoc) source: modules/applications/pages/uid-applications-index.adoc in https://github.com/marcobonita/bonita-doc.git (branch: patch-20)

@marcobonita
Copy link
Contributor Author

@marcobonita Il y a une erreur dans le buld qui dit ceci: [06:24:05.040] FATAL (antora): Page alias cannot reference an existing page: 2024.3@bonita:applications:custom-applications-index.adoc (specified as: applications:custom-applications-index.adoc) source: modules/applications/pages/uid-applications-index.adoc in https://github.com/marcobonita/bonita-doc.git (branch: patch-20)

True, we don't need that alias anymore. I removed it

modules/applications/pages/faq.adoc Outdated Show resolved Hide resolved
@rbioteau rbioteau merged commit 5fe8c86 into bonitasoft:2024.3 Jun 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants