Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(uibuilder): document edge case for Application Link #2746

Merged
merged 7 commits into from
Jun 26, 2024

Conversation

vhemery
Copy link
Contributor

@vhemery vhemery commented Jun 26, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Jun 26, 2024

📝 Check the pages that have been modified

In order to merge this pull request, you need to check your updates with the following url.

🔍 Updated pages

The following pages were updated, please ensure that the display is correct:

Copy link
Contributor

github-actions bot commented Jun 26, 2024

🎊 PR Preview 86d4150 has been successfully built and deployed to https://bonitasoft-bonita-doc-deploy-pr-2746.surge.sh

🕐 Build time: 0.01s

🤖 By surge-preview

Add images and link from release note.
@vhemery vhemery changed the title feat(uibuilder): Document edge case for Application Link feat(uibuilder): document edge case for Application Link Jun 26, 2024
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 12.8%, saving 5.48 KB.

Filename Before After Improvement Visual comparison
modules/applications/assets/images/images/app-link/issueOldLayout.png 42.95 KB 37.47 KB -12.8% View diff

274 images did not require optimisation.

@vhemery vhemery marked this pull request as ready for review June 26, 2024 08:27
Copy link
Contributor

@abirembaut abirembaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion
other that that, it looks good to me

modules/applications/pages/faq.adoc Outdated Show resolved Hide resolved
Co-authored-by: abirembaut <anthony.birembaut@bonitasoft.com>
Co-authored-by: abirembaut <anthony.birembaut@bonitasoft.com>
@vhemery vhemery merged commit ace43d0 into 2024.3 Jun 26, 2024
6 checks passed
@vhemery vhemery deleted the feat/application_link_layout branch June 26, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants