-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: display the "contributing" section in the navbar #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new Antora versions now generate a warning when a nav entry cannot be resolved. This is how the problem has been detected.
🎊 PR Preview 8cab3f4 has been successfully built and deployed to https://bonitasoft-bonita-doc-deploy-pr-2748.surge.sh 🕐 Build time: 0.009s 🤖 By surge-preview |
tbouffard
changed the title
fix: remove non-existing navbar file from Antora configuration
fix: display the "contributing" section in the navbar
Jun 26, 2024
rbioteau
approved these changes
Jun 26, 2024
tbouffard
added a commit
that referenced
this pull request
Jun 27, 2024
The file that was previously referenced in the Antora configuration didn't exist. Use the right one. Note: this is a port of #2748.
tbouffard
added a commit
that referenced
this pull request
Jun 27, 2024
The file that was previously referenced in the Antora configuration didn't exist. Use the right one. Note: this is a port of #2748.
tbouffard
added a commit
that referenced
this pull request
Jun 27, 2024
The file that was previously referenced in the Antora configuration didn't exist. Use the right one. Also - add the missing glossary navigation entries - reorganize "api doc" attributes for consistency Note: this is a port of #2748.
tbouffard
added a commit
that referenced
this pull request
Jun 27, 2024
The file that was previously referenced in the Antora configuration didn't exist. Use the right one. Also - add the missing glossary navigation entries - reorganize "api doc" attributes for consistency Note: this is a port of #2748.
tbouffard
added a commit
that referenced
this pull request
Jun 27, 2024
The file that was previously referenced in the Antora configuration didn't exist. Use the right one. Also - add the missing glossary navigation entries - reorganize "api doc" attributes for consistency Note: this is a port of #2748.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file that was previously referenced in the Antora configuration didn't exist. Use the right one.
Screenshots
Note: this screenshot was done on a site locally built as the surge preview is currently not always updated, and it wasn't after that the 004b247 commit was pushed
Command to locally build the site
Notes
The new Antora versions now generate a warning when a nav entry cannot be resolved. This is how the problem has been detected.
Detected in bonitasoft/bonita-documentation-site#736 (comment)