Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display the "contributing" section in the navbar #2748

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Jun 26, 2024

The file that was previously referenced in the Antora configuration didn't exist. Use the right one.

Screenshots

image

Note: this screenshot was done on a site locally built as the surge preview is currently not always updated, and it wasn't after that the 004b247 commit was pushed

Command to locally build the site

./build-preview-dev.bash \
  --use-multi-repositories \
  --component-with-branches bonita:fix/remove_not_existing_navbar_file \
  --local-sources

Notes

The new Antora versions now generate a warning when a nav entry cannot be resolved. This is how the problem has been detected.
Detected in bonitasoft/bonita-documentation-site#736 (comment)

The new Antora versions now generate a warning when a nav entry cannot be resolved.
This is how the problem has been detected.
Copy link
Contributor

github-actions bot commented Jun 26, 2024

🎊 PR Preview 8cab3f4 has been successfully built and deployed to https://bonitasoft-bonita-doc-deploy-pr-2748.surge.sh

🕐 Build time: 0.009s

🤖 By surge-preview

@tbouffard tbouffard changed the title fix: remove non-existing navbar file from Antora configuration fix: display the "contributing" section in the navbar Jun 26, 2024
@rbioteau rbioteau merged commit 5103c46 into 2022.2 Jun 26, 2024
5 checks passed
@rbioteau rbioteau deleted the fix/remove_not_existing_navbar_file branch June 26, 2024 15:54
tbouffard added a commit that referenced this pull request Jun 27, 2024
The file that was previously referenced in the Antora configuration
didn't exist. Use the right one.

Note: this is a port of #2748.
tbouffard added a commit that referenced this pull request Jun 27, 2024
The file that was previously referenced in the Antora configuration
didn't exist. Use the right one.

Note: this is a port of #2748.
tbouffard added a commit that referenced this pull request Jun 27, 2024
The file that was previously referenced in the Antora configuration
didn't exist. Use the right one.

Also
  - add the missing glossary navigation entries
  - reorganize "api doc" attributes for consistency

Note: this is a port of #2748.
tbouffard added a commit that referenced this pull request Jun 27, 2024
The file that was previously referenced in the Antora configuration
didn't exist. Use the right one.

Also
  - add the missing glossary navigation entries
  - reorganize "api doc" attributes for consistency

Note: this is a port of #2748.
tbouffard added a commit that referenced this pull request Jun 27, 2024
The file that was previously referenced in the Antora configuration
didn't exist. Use the right one.

Also
  - add the missing glossary navigation entries
  - reorganize "api doc" attributes for consistency

Note: this is a port of #2748.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants