Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Autocomplete widget does not update its displayed value #2946

Merged
merged 7 commits into from
Dec 20, 2024

Conversation

jeromecambon
Copy link
Contributor

@jeromecambon jeromecambon commented Dec 19, 2024

Covers UID-733

Copy link
Contributor

github-actions bot commented Dec 19, 2024

📝 Contribution Summary

To merge this Pull Request, you need to check your updates with the following URL.

🔗 Updated pages

Note

The following pages were updated, please ensure that the display is correct:

@jeromecambon jeromecambon changed the title doc : Autocomplete widget does not update its displayed value docs : Autocomplete widget does not update its displayed value Dec 19, 2024
@bonita-ci
Copy link
Contributor

bonita-ci commented Dec 19, 2024

🎊 PR Preview 6b419a7 has been successfully built and deployed to https://bonitasoft-bonita-doc-deploy-pr-2946.surge.sh

🕐 Build time: 0.01s

🤖 By surge-preview

@jeromecambon jeromecambon changed the title docs : Autocomplete widget does not update its displayed value docs: Autocomplete widget does not update its displayed value Dec 19, 2024
@benjaminParisel
Copy link
Contributor

image

I am not satisfied with the result. I suggest to move the troubleshooting section in the dedicated widget part.

I push a commit to do it, feel free to rollback if you think it's better before.

@jeromecambon
Copy link
Contributor Author

jeromecambon commented Dec 19, 2024

@benjaminParisel
I think that including the troubleshooting in the widget description make the page less readable, and would "pollute" the widget descriptions. However, adding a pointer from the widget description to the dedicated troubleshooting (if any) would provide a good alternative, and avoid to miss it. What do you think?

@benjaminParisel
Copy link
Contributor

@benjaminParisel I think that including the troubleshooting in the widget description make the page less readable, and would "pollute" the widget descriptions. However, adding a pointer from the widget description to the dedicated troubleshooting (if any) would provide a good alternative, and avoid to miss it. What do you think?

Do what you think is better and more readable but please, don't put three troubleshooting titles and icon (like we can see on the screen)

@jeromecambon
Copy link
Contributor Author

@benjaminParisel I think that including the troubleshooting in the widget description make the page less readable, and would "pollute" the widget descriptions. However, adding a pointer from the widget description to the dedicated troubleshooting (if any) would provide a good alternative, and avoid to miss it. What do you think?

Do what you think is better and more readable but please, don't put three troubleshooting titles and icon (like we can see on the screen)

I kept the same formatting already in place, but yes we should use the example we provided here: https://bonitasoft.github.io/bonita-documentation-theme/troubleshooting.html

@benjaminParisel benjaminParisel self-requested a review December 20, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants