ci: better support PR from fork for preview build and ref validation #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only valid for a branch preview for a component. This allows you to use an alternative URL to the one configured for the component, in particular to use a fork.
|
♻️ PR Preview 1bd62c0 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 1bd62c0 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
…ork repo url (again) [skip ci]
…o support It is still possible to pass a custom build preview command (no change for workflow using this action).
tbouffard
changed the title
…iscovery is completed [skip ci]
…ss the component-name
|
7 tasks
benjaminParisel
deleted the
feat/build_single_component_with_branch_from_forked_repo
branch
benjaminParisel
pushed a commit
to bonitasoft/bonita-doc
that referenced
this pull request
Apr 17, 2024
This applies to the "build preview" and the "references validation". The content of the branch of the fork is now correctly used. Previously, the branch of the fork wasn't found by Antora, so the content of the generated site was empty. ### Notes Covers bonitasoft/bonita-documentation-site#402 This depends on bonitasoft/bonita-documentation-site#698
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let pass the git repo url to the preview script:
The "build-and-publish-pr-preview" and the "build-pr-site" (used for references validation) actions set this new argument to use the git URL of the branch of the PR
This ensures that the git URL of the repository whose the PR is originated from is used (fork or upstream repository).
Covers #402
Notes
Validation done for