ci: make PR surge deployments work with both site and test #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was not working as the 2 workflow used to deployed called the same reusable workflow that deployed to the same URL for the 2 environments. This was because the URL is computed using the job id of the reusable workflow. So for "test" deployment, duplicate the logic of the reusable workflow to have a dedicated URL. In the "deploy" reusable workflow, use a shorter job id. It is used to compute the URL of all deployments. A shorter name ensure that we don't try to generate a too large URL subdomain. The PR comment relative to the changes will be managed by a dedicated workflow in the future for a better separation of concerns, to simplify the maintenance and to make things more explicit. So remove the related steps (that was still a work in progress) from the reusable workflow in charge of the deployment.
…est_and_site [skip ci]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not working as the 2 workflow used to deployed called the same reusable workflow that deployed to the same URL for the 2 environments. This was because the URL is computed using the job id of the reusable workflow.
So for "test" deployment, duplicate the logic of the reusable workflow to have a dedicated URL.
In the "deploy" reusable workflow, use a shorter job id. It is used to compute the URL of all deployments. A shorter name ensure that we don't try to generate a too large URL subdomain.
The PR comment relative to the changes will be managed by a dedicated workflow in the future for a better separation of concerns, to simplify the maintenance and to make things more explicit. So remove the related steps (that was still a work in progress) from the reusable workflow in charge of the deployment.
Covers #686