Consolidate shared menu icons in global resources #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glopesdev
force-pushed
the
issue-1988
branch
from
a94b9f9 to
4bf46a8
Compare
PathogenDavid
approved these changes
Sep 11, 2024
| @@ -1317,7 +1316,6 @@ private void InitializeComponent() | |||
| // | |||
| // workflowFileWatcher | |||
| // | |||
| this.workflowFileWatcher.EnableRaisingEvents = false; | |||
There was a problem hiding this comment.
For posterity: This is the default value for EnableRaisingEvents, this is just the designer cleaning up an unnecessary assignment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves shared form embedded resources into the global
Resources.resxfile to avoid having the designer create duplicate entries with identical embedded binary image data.This stems from a long standing quirk of the designer where it will reserialize resources multiple times into different entries in the local embedded resources file instead of referencing, unless images come from the shared project resources. This is done silently and automatically on opening the designer, so it is very easy for the duplication to go unnoticed.
Fixes #1988