Enable switching of dark and light theme image for Bonsai logo #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glopesdev
reviewed
Nov 8, 2024
There was a problem hiding this comment.
@banchan86 this looks great, the solution of using the logo id class in CSS is particularly neat. I couldn't find a reference to it anywhere other than this docfx discussion and subsequent internal links in comments.
Let us know if you have any better references for why this solution works, so we can keep track of it and change it in the future when browser support improves (EDIT: sorry I missed the link in the original issue, looks great).
P.S.: I guess for other package websites we don't need to worry about this, since we have been using regular text rather than logo-embedded lettering, which is great.
glopesdev
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98