-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First package draft #1
base: main
Are you sure you want to change the base?
Conversation
Added a small example of how to derive from the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a jab at this, looks good. I left full feedback, but I'm also happy to go directly into the branch and help edit these, whatever is more convenient.
Bonsai.Ximea/Externals/xiapi64.dll
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 70 MB is too much to store in a git repo, especially when it is likely we will need to update these binaries at a later date. In this case what we should probably do is leave in this folder a README file with instructions on how to download and install the correct version of the library from where to pull the dependencies.
The build process can still point to this folder and package the binaries in the .nupkg but this would be for the NuGet distribution only.
Hey guys, I don't see anything here to set FPS, but that was one modification we needed to make. @bruno-f-cruz I think you started it, but here's our Important piece was setting the acquisition timing mode: // Refs:
// https://www.ximea.com/support/wiki/apis/XiAPINET_Manual#ACQ_TIMING_MODE
// https://www.ximea.com/support/wiki/allprod/Frame_Rate_Control
camera.SetParam(PRM.ACQ_TIMING_MODE, ACQ_TIMING_MODE.FRAME_RATE_LIMIT);
camera.SetParam(PRM.FRAMERATE, FrameRate); |
Heya! |
I just wanted to add |
pinging @bruno-f-cruz @glopesdev |
This PR adds a first draft of the package including: