Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexport DB init helpers, add control for observability #19

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

vearutop
Copy link
Member

No description provided.

Copy link

Lines Of Code

Language Files Lines Code Comments Blanks Complexity Bytes
Go 37 2275 (+9) 1651 (+5) 173 (+2) 451 (+2) 269 (+2) 56.1K (+455B)

Copy link

Unit Test Coverage

total: (statements) 42.0%
changed lines: (statements) 0.0%, coverage is less than 90.0%, consider testing the changes more thoroughly

Coverage of changed lines
File Function Coverage
Total 0.0%
database/observability.go 0.0%
database/observability.go:18 withTracing 0.0%
database/observability.go:23 driverNameWithTracing 0.0%
database/observability.go:38 withQueriesLogging 0.0%
database/observability.go:43 driverNameWithQueriesLogging 0.0%
database/observability.go:47 wrapOptions 0.0%
database/observability.go:80 observe 0.0%
database/storage.go 0.0%
database/storage.go:22 SetupStorage 0.0%
database/storage.go:32 SetupStorageDSN 0.0%
database/config.go no coverage
Coverage diff with base branch
File Function Base Coverage Current Coverage
Total 42.2% 42.0% (-0.2%)
database/observability.go DriverNameWithQueriesLogging 0.0% no function
database/observability.go DriverNameWithTracing 0.0% no function
database/observability.go WithQueriesLogging 0.0% no function
database/observability.go WithTracing 0.0% no function
database/observability.go driverNameWithQueriesLogging no function 0.0%
database/observability.go driverNameWithTracing no function 0.0%
database/observability.go withQueriesLogging no function 0.0%
database/observability.go withTracing no function 0.0%

Copy link

Benchmark Result

Benchmark diff with base branch
Module github.com/bool64/dev not found, downloading.
name          old time/op    new time/op    delta
CallerFunc-4    1.30µs ± 1%    1.30µs ± 1%   ~     (p=0.227 n=6+6)

name          old alloc/op   new alloc/op   delta
CallerFunc-4      280B ± 0%      280B ± 0%   ~     (all equal)

name          old allocs/op  new allocs/op  delta
CallerFunc-4      4.00 ± 0%      4.00 ± 0%   ~     (all equal)
Benchmark result
name          time/op
CallerFunc-4  1.30µs ± 1%

name          alloc/op
CallerFunc-4    280B ± 0%

name          allocs/op
CallerFunc-4    4.00 ± 0%

@vearutop vearutop merged commit 924c278 into master Nov 16, 2024
6 of 7 checks passed
@vearutop vearutop deleted the unexport-db-helpers branch November 16, 2024 17:27
Copy link

Go API Changes

# github.com/bool64/brick/database
## incompatible changes
Config: old is comparable, new is not
DriverNameWithQueriesLogging: removed
DriverNameWithTracing: removed
WithQueriesLogging: removed
WithTracing: removed
## compatible changes
Config.MethodSkipPackages: added

# summary
Inferred base version: v0.2.5
Suggested version: v0.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant