This removes test project ID that will conflict with modular ID. #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he modular project IDs for all libraries.
ldionne
approved these changes
Mar 4, 2024
|
I am not sure whether you want this merged right away or whether you need to wait before you do it -- please merge at your discretion. Thanks! |
|
@ldionne I don't have permission to merge. And, yes, it would be great if it gets merged as soon as possible. |
|
PS. I just noticed I created the PR for master. Can you also apply it to the develop branch? |
|
Everything happens on |
|
Well that's not supposed to happen, develop should at least be kept in sync, even if unused. |
|
I just synced the branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the superfluous test project ID that will conflict with the modular project IDs for all libraries. When libraries are modular they will have the standard global ID of /boost/lib-name. Having colliding IDs will cause build errors.
#modular-boost https://github.com/users/grafikrobot/projects/1