Remove test of deprecated functionality #1073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jzmaddock : Always debatable whether we want to remove deprecated functionality from the CI tests; I'll let you decide on whether to merge or close. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1073 +/- ##
===========================================
+ Coverage 85.22% 85.30% +0.07%
===========================================
Files 877 871 -6
Lines 66819 66771 -48
===========================================
+ Hits 56948 56956 +8
+ Misses 9871 9815 -56 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
NAThompson
force-pushed
the
remove_deprecations
branch
from
2b687e6 to
97726ac
Compare
The CI build logs are getting hard to read. Slowly chip away at the warnings emitted.
NAThompson
force-pushed
the
remove_deprecations
branch
from
97726ac to
6235abf
Compare
|
I'd vote leave the testing until we remove the functionality. |
|
Sorry, missed this, I agree with Matt, if we provide we should test it, deprecated or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI build logs are getting hard to read. Slowly chip away at the warnings emitted.