Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connection_pool destructor now cancels async operations #372

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

anarthal
Copy link
Collaborator

Improved connection_pool docs on thread-safety.

close #370

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.04%. Comparing base (6842c2d) to head (a6fe66d).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #372   +/-   ##
========================================
  Coverage    99.04%   99.04%           
========================================
  Files          143      143           
  Lines         7154     7157    +3     
========================================
+ Hits          7086     7089    +3     
  Misses          68       68           
Files with missing lines Coverage Δ
include/boost/mysql/connection_pool.hpp 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6842c2d...a6fe66d. Read the comment docs.

@anarthal anarthal merged commit eba723f into develop Oct 14, 2024
6 checks passed
@anarthal anarthal deleted the feature/370-pool-cancel-on-destroy branch October 14, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

connection_pool should cancel operations when destroyed
1 participant